search

census-instrumentation / opencensus-go

A stats collection and distributed tracing framework
http://opencensus.io
Apache License 2.0
2.06k stars 327 forks source link

Implement server and client `completed_rpcs` (#1214) #1216

Closed smhendrickson closed 4 years ago

smhendrickson commented 4 years ago

The previous implementation appears to be a copy-paste error that directed data into the latency metric, but never recorded data preserving the latency measure accuracy. This cl implements the completed_rpcs measure by incrementing by 1 for each handleRPCEnd call.

The measure is broken down by method and status.

smhendrickson commented 4 years ago

@rghetia agreed. I've just checked my metrics and can confirm completed_rpcs is exported with the intended breakdowns. Not sure why I missed it and went digging before.

With that in mind I can either reduce this pr to an informative comment, or keep it as is. I find the PR more straightforward but it really depends how efficient you want the plugin to be. Up to you all.

RE: CLA not sure why this isn't working. My @google email should get his to pass. Will keeping looking.

rghetia commented 4 years ago

With that in mind I can either reduce this pr to an informative comment, or keep it as is. I find the PR more straightforward but it really depends how efficient you want the plugin to be. Up to you all.

I would go with an informative comment.

smhendrickson commented 4 years ago

https://github.com/census-instrumentation/opencensus-go/pull/1217 created for the comment.

Unsure if it is correct form to create a new PR for something like that, but thats what happens when I don't use github (or git) for years 🤷‍♂️