search

census-instrumentation / opencensus-go

A stats collection and distributed tracing framework
http://opencensus.io
Apache License 2.0
2.06k stars 327 forks source link

Set up Github Actions for pull request validation #1237

Closed jsuereth closed 3 years ago

jsuereth commented 3 years ago

Example of it working: https://github.com/jsuereth/opencensus-go/pull/1/checks

nilebox commented 3 years ago

What is the ultimate plan here? Migrate all projects from Travis to GitHub Actions? FWIW we use CircleCI in opentelemetry-operations-go and other OpenTelemetry / Google Cloud repos, so it would be useful to have a unified CI approach across all OpenCensus / OpenTelemetry projects.

jsuereth commented 3 years ago

What is the ultimate plan here? Migrate all projects from Travis to GitHub Actions? FWIW we use CircleCI in opentelemetry-operations-go and other OpenTelemetry / Google Cloud repos, so it would be useful to have a unified CI approach across all OpenCensus / OpenTelemetry projects.

Interesting. I choose GHA because (most of) OpenTelemetry is using it and because I agree we should have a unified approach. Primary goal of this CL was to figure out how expensive it would be to migrate (not very), secondary goal was to unify the projects in terms of technology if we're going to maintain both for while. Given that OC is directly moving to OT, I thought unifying with OSS OT community would be better. It appears that within OT, (JS/Go APIs, Collector + Specification) use CircleCI and the spot check I did (swift, c++, java, .NET, erlang, Python, JavaScript) use GHA. I'm curious why there's such divergence between the repositories, do you know why to choose CircleCI over GHA?