search

census-instrumentation / opencensus-go

A stats collection and distributed tracing framework
http://opencensus.io
Apache License 2.0
2.05k stars 327 forks source link

Add started RPC metric for client and server side #1283

Closed zasweq closed 1 year ago

dashpole commented 1 year ago

/bin/sh: 1: goimports: not found

Seems like CI is broken

dashpole commented 1 year ago

This will need to be rebased on https://github.com/census-instrumentation/opencensus-go/pull/1284 after it merges.

zasweq commented 1 year ago

Yeah, will do once it's merged. Thanks.

dashpole commented 1 year ago

test fix PR is merged. Feel free to rebase

zasweq commented 1 year ago

Done. Thanks.

dashpole commented 1 year ago 
goimports FAILED => goimports the following files:
make: *** [Makefile:49: imports] Error 1

./plugin/ocgrpc/client_metrics.go
./plugin/ocgrpc/end_to_end_test.go
./plugin/ocgrpc/server_metrics.go
dashpole commented 1 year ago

I think you might need a go fmt ./...