search

census-instrumentation / opencensus-node

A stats collection and distributed tracing framework
https://opencensus.io
Apache License 2.0
273 stars 96 forks source link

@opencensus/core types.js #137

Open wesfl opened 6 years ago

wesfl commented 6 years ago

Hi there,

I'm brand new to both OpenCensus and TypeScript so apologies ahead of time if there's something I'm misunderstanding.

After npm i-ing @opencensus/core (which resolved to 0.0.4), I encountered an issue where the enum-s in build/src/stats/types.d.ts aren't represented in build/src/stats/types.js which lead to runtime errors like

Cannot read property 'KBYTE' of undefined

I pulled the opencensus-node project, and executed npm run compile, and the resulting types.js included code for those enum-s.

My initial thought is that @opencensus/core simply needs a new version published after a successful build. So, I wanted to submit an issue for discussion on this.

BrianChristie commented 6 years ago

I can confirm, I've tested the NodeJS Metrics QuickStart with the current master of opencensus/core and it works successfully.

Can we get a new release cut and pushed to NPM?

songy23 commented 6 years ago

@kjin could you do a new release to NPM?