search

census-instrumentation / opencensus-python

A stats collection and distributed tracing framework
Apache License 2.0
668 stars 250 forks source link

[Bug fix] Allow redirects for proxy #1229

Closed GrantAnt closed 1 year ago

GrantAnt commented 1 year ago

In the current implementation, proxies are offered but not usable. In case requests library has proxy options set, allow_redirect needs to be set to true.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

GrantAnt commented 1 year ago

@lzchen Build Job for py39 failed. It seems not be connected to my code changes and last week the build was working on master. Just restart build tool?

lzchen commented 1 year ago

@GrantAnt

Looks like build is failing for lint.

GrantAnt commented 1 year ago

@lzchen which linter is executed? Can I run it locally?

lzchen commented 1 year ago

@GrantAnt

image

Looks like it's flake8. You can see the lint steps here: https://github.com/census-instrumentation/opencensus-python/blob/master/tox.ini#L68

GrantAnt commented 1 year ago

@lzchen How could I be so blind. Thank you so much :) Whitespaces are resolved now