census-instrumentation / opencensus-python

A stats collection and distributed tracing framework
Apache License 2.0
669 stars 250 forks source link

opencensus.ext.grpc has no "trace" module #677

Closed allenjohnashton closed 5 years ago

allenjohnashton commented 5 years ago

Describe your environment. Python 2.7


  'opencensus-ext-flask==0.3.1' \                                                                                                                                                                                                                                                     
  'opencensus-ext-gevent==0.1.0' \                                                                                                                                                                                                                                                    
  'opencensus-ext-google-cloud-clientlibs==0.1.2' \                                                                                                                                                                                                                                   
  'opencensus-ext-grpc==0.3.0' \                                                                                                                                                                                                                                                      
  'opencensus-ext-logging==0.1.0' \                                                                                                                                                                                                                                                   
  'opencensus-ext-postgresql==0.1.2' \                                                                                                                                                                                                                                                
  'opencensus-ext-stackdriver==0.4.0' \                                                                                                                                                                                                                                               
  'opencensus-ext-requests==0.1.2' \                                                                                                                                                                                                                                                  
  'opencensus-ext-sqlalchemy==0.1.2' \                                                                                                                                                                                                                                                
  'opencensus-ext-threading==0.1.2' \  ```

**Steps to reproduce.**
Follow instructions for trace integration.

**What is the expected behavior?**
Trace integration working

**What is the actual behavior?**
 trace_sampled=False Failed to integrate module: opencensus.ext.grpc.trace
No module named trace

**Additional context.**
Looking at other modules I see a trace.py.  Looks like grpc does not have one for now.
reyang commented 5 years ago

This seems to be a doc issue, the grpc integration is done by explicitly using the interceptors (refer to the examples) instead of through config_integration.

c24t commented 5 years ago

@allenjohnashton which instructions are you following? It'd help if you could post the code that gives you the error.

allenjohnashton commented 5 years ago

@c24t Sorry I did not update because @reyang was correct. The docs were incorrect. I see he has linked cl so I am assuming no further clarification was needed.