census-instrumentation / opencensus-ruby

A stats collection and distributed tracing framework
Apache License 2.0
91 stars 23 forks source link

Fix stats example #119

Open directionless opened 5 years ago

directionless commented 5 years ago

This fixes the stats example.

~Exporters don’t work.~

But I’m sure my comments are wrong. But it’s a start

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

directionless commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

dazuma commented 5 years ago

@jiren Can you review this and verify it's in line with the current stats code?

jiren commented 5 years ago

@jiren Can you review this and verify it's in line with the current stats code?

Yes, look good as per current stats code.

Just for information, this example needs to be updated once the Tag metadata code is merged.