mads-hartmann commented 5 years ago

The datadog exporter will currently drop the service name which is specified in the spans. See https://github.com/census-instrumentation/opencensus-service/issues/198 for more information.

This aligns the datadog exporter with jaeger, wavefront, and zipkin. They already have this option.

A better solution would be to add support for multiple services, as many of the other exporters have, but that is a bit over the level of contribution I can do at the moment.

I've tested this against a live datadog setup and the service name is correctly propagated and displayed in their UI.

If you are okay with this contribution I will update the docs accordingly 😊

codecov[bot] commented 5 years ago

Codecov Report

Merging #602 into master will decrease coverage by 0.01%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   68.87%   68.86%   -0.02%     
==========================================
  Files          92       92              
  Lines        6066     6067       +1     
==========================================
  Hits         4178     4178              
- Misses       1669     1670       +1     
  Partials      219      219

Impacted Files	Coverage Δ
exporter/datadogexporter/datadog.go	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b8085d...a2cd9d2. Read the comment docs.

mads-hartmann commented 5 years ago

@pjanotti no problem 😊 thanks for reviewing.

census-instrumentation / opencensus-service

Add support for specifying service name in config #602

Codecov Report