census-instrumentation / opencensus-website

opencensus.io website content
https://opencensus.io
Apache License 2.0
42 stars 155 forks source link

Adds a Honeycomb example to the Service section #697

Closed akvanhar closed 5 years ago

akvanhar commented 5 years ago

This adds an end-to-end example to the Honeycomb section of Service/Exporters

odeke-em commented 5 years ago

@songy23 actually we want to keep the /agent/ aliases since the new route is for /service so it doesn't make sense for aliases to point to themselves :)

On Tue, Jun 11, 2019 at 9:39 AM Yang Song notifications@github.com wrote:

@songy23 approved this pull request.

LGTM overall

In content/service/exporters/honeycomb/_index.md https://github.com/census-instrumentation/opencensus-website/pull/697#discussion_r292551406 :

@@ -1,42 +1,11 @@


title: "Honeycomb"

-date: 2019-02-17T22:57:58-08:00

+date: 2019-06-10T18:25:17-08:00

aliases: [/agent/exporters/honeycomb]

⬇️ Suggested change

  • aliases: [/agent/exporters/honeycomb]

+aliases: [/service/exporters/honeycomb]


In content/service/exporters/honeycomb/tracing.md https://github.com/census-instrumentation/opencensus-website/pull/697#discussion_r292551460 :

@@ -0,0 +1,91 @@

+---

+title: "Traces"

+date: 2019-06-10T18:25:17-08:00

+aliases: [/agent/exporters/honeycomb/traces]

⬇️ Suggested change

-aliases: [/agent/exporters/honeycomb/traces]

+aliases: [/service/exporters/honeycomb/traces]

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/census-instrumentation/opencensus-website/pull/697?email_source=notifications&email_token=ABFL3VZ3HWF5JIUQLP6E75DPZ7IKJA5CNFSM4HXAB4E2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3GL57I#pullrequestreview-248299261, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFL3V6MTOB2PMNSCXTKAPDPZ7IKJANCNFSM4HXAB4EQ .

songy23 commented 5 years ago

I see, thanks for the explanation.

akvanhar commented 5 years ago

@songy23 actually we want to keep the /agent/ aliases since the new route is for /service so it doesn't make sense for aliases to point to themselves :)

Whoops! I was too fast on that change :) Changing it back to agent/exporters 👍