census-instrumentation / opencensus-website

opencensus.io website content
https://opencensus.io
Apache License 2.0
42 stars 155 forks source link

improved documentation for gRPC opencensus tracing example #731

Closed Wathis closed 4 years ago

Wathis commented 4 years ago

grpc.WithStatsHandler(new(ocgrpc.ClientHandler)) and grpc.StatsHandler(&ocgrpc.ServerHandler{}) were omitted for tracing example on the client and the server ( they were only present on metrics and combined )

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Wathis commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.