centau / vide

A reactive Luau library for creating UI.
https://centau.github.io/vide/
MIT License
95 stars 16 forks source link

fix recursive queue flush #28

Closed alicesaidhi closed 3 months ago

alicesaidhi commented 3 months ago

do u know how hard it is to solve recursive queue flushing

fixes a bug where a effect calling batch would result in a recursive queue flush due to it updating the effect too. also removes the error since the behavior for it changed to start flushing from when the batch call was started rather than flushing the entire update_queue

centau commented 3 months ago

your unit tests aren't nearly comprehensive enough, you only check if the assertion still exists and not if batching within reactive scopes actually work in various graph setups

centau commented 3 months ago

image

why swap this?

the order decides if deferred evaluations from batching will be batched themselves, you've chosen that they won't - why?

centau commented 3 months ago

this is turning a footgun into a footbomb