search

center-for-threat-informed-defense / attack-flow

Attack Flow helps executives, SOC managers, and defenders easily understand how attackers compose ATT&CK techniques into attacks by developing a representation of attack flows, modeling attack flows for a small corpus of incidents, and creating visualization tools to display attack flows.
https://ctid.io/attack-flow
Apache License 2.0
527 stars 84 forks source link

Publish quality attack flow diagrams. #43

Closed curious-attempt-bunny closed 2 years ago

curious-attempt-bunny commented 2 years ago

Fixes #42

What Changed

  1. Tidied up graphviz script output. Now it aligns better with the style of the manually created drawio diagrams.

Before

image

After

image

Limitations

  1. Layout! (it's graphviz)
  2. Text exceeding the fixed sized nodes.
curious-attempt-bunny commented 2 years ago

@mehaase I addressed the feedback.

I also added documentation for running the tests, added the flake checks to the makefile, and duplicated the flake8 configuration so that it's picked up out of the box by the MS Visual Studio plugin.

codecov[bot] commented 2 years ago

Codecov Report

Merging #43 (a7db577) into main (958189a) will increase coverage by 0.58%. The diff coverage is 100.00%.

:exclamation: Current head a7db577 differs from pull request most recent head 2aae729. Consider uploading reports for the commit 2aae729 to get more accurate results

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   96.81%   97.40%   +0.58%     
==========================================
  Files           5        5              
  Lines         220      270      +50     
==========================================
+ Hits          213      263      +50     
  Misses          7        7
Impacted Files Coverage Δ
src/attack_flow/graphviz.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 958189a...2aae729. Read the comment docs.

curious-attempt-bunny commented 2 years ago

@mehasse Cleaned up. Thanks for your time reviewing these changes.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mehaase commented 2 years ago

Thank you for the contribution @curious-attempt-bunny! This will definitely be valuable to the community at large.