Closed anvilogic-KLo closed 1 year ago
Base: 99.75% // Head: 99.75% // No change to project coverage :thumbsup:
Coverage data is based on head (
afb390f
) compared to base (a3800be
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thank you for the PR! A couple items of feedback:
technique_ref
is for the STIX ID of the ATT&CK technique (or any other STIX attack-pattern). The text you have in there typically goes in the name field. We will improve this aspect in the next release.I'm uploading a copy with some of these changes applied. Please take a look.
Good evening Mark and CTID team,
Thank you for the feedback and the workshop session for Attack flow, definitely an insightful conversation. I’ll note these changes for the next iterations. To give some insight the attached afb file, is our modifications to the builder to accommodate fields we use at Anvilogic
Thank you again for the time today!
Respectfully, Kevin
On Dec 7, 2022, at 1:57 PM, Mark E. Haase @.***> wrote:
Thank you for the PR! A couple items of feedback:
I'm uploading a copy with some of these changes applied. Please take a look.
DFIR - BumbleBee Round 2.afb.txt https://github.com/center-for-threat-informed-defense/attack-flow/files/10179153/DFIR.-.BumbleBee.Round.2.afb.txt
— Reply to this email directly, view it on GitHub https://github.com/center-for-threat-informed-defense/attack-flow/pull/53#issuecomment-1341429947, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZVYGP42RZHNH5LV7N46UDWMDMZHANCNFSM6AAAAAARXOY7Y4 . You are receiving this because you authored the thread.Message ID: @.*** com>
Closing this PR and finishing this flow in #75.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information