center-for-threat-informed-defense / attack-powered-suit

ATT&CK Powered Suit is a browser extension that puts the complete MITRE ATT&CK® knowledge base at your fingertips with text search, context menus, and ATT&CK Navigator integration.
https://ctid.io/attack-powered-suit
Apache License 2.0
73 stars 12 forks source link

Missing search results for procdump #16

Closed clr2of8 closed 1 year ago

clr2of8 commented 2 years ago

When I search for procdump on the mitre site I get results

image

But I don't when searching with the extension

image

clr2of8 commented 2 years ago

I also see missing search results in the search for Base64 as shown in the image below: image

mehaase commented 1 year ago

I'm taking a look at this today. The text search library (fuse.js) has a limited match distance, so if keywords are more than 1000 characters into the description, it seems that fuse.js will not find them. I tried increasing the match distance to 10,000 to confirm this.

While increasing the match distance does improve the situation a bit, I think fuse.js is a deadend for this project. The better solution would be to replace fuse.js with something more appropriate for our needs (see #4).

mehaase commented 1 year ago

This should be fixed in #28 and will be included in 1.2.0 release in the next couple weeks.

mehaase commented 1 year ago

Some screenshots to show how the new search engine handles the problematic queries posted by @clr2of8:

Screen Shot 2022-12-20 at 3 03 08 PM Screen Shot 2022-12-20 at 3 03 24 PM
clr2of8 commented 1 year ago

Thanks Mark!