center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
41 stars 22 forks source link

Absorbing Collection Manager REST API #261

Closed elegantmoose closed 1 year ago

elegantmoose commented 1 year ago

Primary PR for absorbing the collection manager REST API into the workbench REST API.

*There will be a corresponding PR in the Workbench Frontend repo, updating all references, connections to former collection manager. -> https://github.com/center-for-threat-informed-defense/attack-workbench-frontend/pull/477/

*Also, just noticed WB-11 is not the right JIRA ticket number so Im confused on why I called this branch WB-11 to begin with, but FYSA.

Notes:

elegantmoose commented 1 year ago

Just noticed the static check errors. Looking into.

elegantmoose commented 1 year ago

@ElJocko @clemiller - Hold off for the moment. Looks like I had some changes not get committed. Will ping when cleared up.

elegantmoose commented 1 year ago

@ElJocko @clemiller Good to restart review. There is still 2 errors from the static checks but I dont agree with the suggested changed (lol).

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 7.53% and project coverage change: -2.26 :warning:

Comparison is base (fe73502) 70.40% compared to head (55b8357) 68.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #261 +/- ## =========================================== - Coverage 70.40% 68.14% -2.26% =========================================== Files 118 121 +3 Lines 16085 16679 +594 Branches 2178 2181 +3 =========================================== + Hits 11324 11366 +42 - Misses 4754 5306 +552 Partials 7 7 ``` | [Impacted Files](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense) | Coverage Δ | | |---|---|---| | [app/lib/authenticated-request.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL2xpYi9hdXRoZW50aWNhdGVkLXJlcXVlc3QuanM=) | `0.00% <0.00%> (ø)` | | | [app/scheduler/scheduler.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL3NjaGVkdWxlci9zY2hlZHVsZXIuanM=) | `0.00% <0.00%> (ø)` | | | [app/services/authentication-service.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL3NlcnZpY2VzL2F1dGhlbnRpY2F0aW9uLXNlcnZpY2UuanM=) | `0.00% <0.00%> (ø)` | | | [app/controllers/collection-indexes-controller.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL2NvbnRyb2xsZXJzL2NvbGxlY3Rpb24taW5kZXhlcy1jb250cm9sbGVyLmpz) | `60.66% <15.00%> (-7.03%)` | :arrow_down: | | [app/services/collections-service.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL3NlcnZpY2VzL2NvbGxlY3Rpb25zLXNlcnZpY2UuanM=) | `60.29% <20.93%> (-3.87%)` | :arrow_down: | | [app/services/collection-indexes-service.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL3NlcnZpY2VzL2NvbGxlY3Rpb24taW5kZXhlcy1zZXJ2aWNlLmpz) | `50.26% <26.53%> (-8.31%)` | :arrow_down: | | [app/config/config.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL2NvbmZpZy9jb25maWcuanM=) | `95.88% <100.00%> (+0.15%)` | :arrow_up: | | [app/routes/collection-indexes-routes.js](https://app.codecov.io/gh/center-for-threat-informed-defense/attack-workbench-rest-api/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=center-for-threat-informed-defense#diff-YXBwL3JvdXRlcy9jb2xsZWN0aW9uLWluZGV4ZXMtcm91dGVzLmpz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.