Closed elegantmoose closed 1 year ago
Just noticed the static check errors. Looking into.
@ElJocko @clemiller - Hold off for the moment. Looks like I had some changes not get committed. Will ping when cleared up.
@ElJocko @clemiller Good to restart review. There is still 2 errors from the static checks but I dont agree with the suggested changed (lol).
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells
No Coverage information
0.0% Duplication
Patch coverage: 7.53
% and project coverage change: -2.26
:warning:
Comparison is base (
fe73502
) 70.40% compared to head (55b8357
) 68.14%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Primary PR for absorbing the collection manager REST API into the workbench REST API.
*There will be a corresponding PR in the Workbench Frontend repo, updating all references, connections to former collection manager. -> https://github.com/center-for-threat-informed-defense/attack-workbench-frontend/pull/477/
*Also, just noticed WB-11 is not the right JIRA ticket number so Im confused on why I called this branch WB-11 to begin with, but FYSA.
Notes: