308 refactor assets service for improved structure and asychronicity

seansica commented 11 months ago

Closes #308

ElJocko commented 11 months ago

The assets controller also needs to be modified to use the new exceptions. Running the api tests causes a timeout when trying to add an asset with duplicate stix.id and stix.modified (I think the timeout is caused by the controller throwing when trying to reference assetsService.errors and the exception isn't caught)

codecov[bot] commented 11 months ago

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
app/lib/model-names.js	`100.00% <100.00%> (ø)`
app/models/asset-model.js	`100.00% <100.00%> (ø)`
app/models/campaign-model.js	`100.00% <100.00%> (ø)`
app/models/collection-model.js	`100.00% <100.00%> (ø)`
app/models/data-component-model.js	`100.00% <100.00%> (ø)`
app/models/data-source-model.js	`100.00% <100.00%> (ø)`
app/models/group-model.js	`100.00% <100.00%> (ø)`
app/models/identity-model.js	`100.00% <100.00%> (ø)`
app/models/marking-definition-model.js	`100.00% <100.00%> (ø)`
app/models/matrix-model.js	`100.00% <100.00%> (ø)`
... and 26 more