center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactor tactics service #310

Closed vsun757 closed 10 months ago

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.0% 16.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

codecov[bot] commented 10 months ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Files Coverage Δ
app/repository/groups-repository.js 100.00% <100.00%> (ø)
app/repository/tactics-repository.js 100.00% <100.00%> (ø)
app/services/techniques-service.js 70.00% <100.00%> (-0.45%) :arrow_down:
app/services/tactics-service.js 84.44% <85.96%> (+21.86%) :arrow_up:
app/controllers/tactics-controller.js 69.41% <56.43%> (+0.73%) :arrow_up:

:loudspeaker: Thoughts on this report? Let us know!