search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored groups service #313

Closed vsun757 closed 10 months ago

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
14.7% 14.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

codecov[bot] commented 10 months ago

Codecov Report

Attention: 241 lines in your changes are missing coverage. Please review.

Files Coverage Δ
app/controllers/assets-controller.js 68.57% <100.00%> (+0.54%) :arrow_up:
app/exceptions/index.js 81.08% <100.00%> (+1.27%) :arrow_up:
app/repository/_base.repository.js 80.68% <100.00%> (+16.68%) :arrow_up:
app/repository/assets-repository.js 100.00% <100.00%> (ø)
app/repository/groups-repository.js 100.00% <100.00%> (ø)
app/repository/matrix-repository.js 100.00% <100.00%> (ø)
app/services/assets-service.js 100.00% <100.00%> (ø)
app/services/collection-bundles-service.js 78.79% <100.00%> (+0.78%) :arrow_up:
app/services/groups-service.js 100.00% <100.00%> (+30.64%) :arrow_up:
app/repository/user-accounts-repository.js 0.00% <0.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!

seansica commented 10 months ago

Regression tests are now succeeding. This branch should be ready to merge.