center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored notes service for improved structure and asynchronicity #316

Closed vsun757 closed 8 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (1125eab) 68.24% compared to head (ab23273) 68.40%. Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/controllers/notes-controller.js 49.47% 48 Missing :warning:
app/services/notes-service.js 45.45% 18 Missing :warning:
app/repository/notes-repository.js 77.33% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #316 +/- ## ================================================= + Coverage 68.24% 68.40% +0.16% ================================================= Files 146 146 Lines 15737 15488 -249 Branches 1887 1837 -50 ================================================= - Hits 10740 10595 -145 + Misses 4989 4885 -104 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
38.0% 38.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

ElJocko commented 9 months ago

closes #296

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

39.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud