search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored campaigns service for improved structure and asynchronicity #321

Closed vsun757 closed 9 months ago

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.0% 17.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

codecov[bot] commented 9 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b937d43) 67.83% compared to head (4d85b81) 68.03%. Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/controllers/campaigns-controller.js 64.55% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #321 +/- ## ================================================= + Coverage 67.83% 68.03% +0.19% ================================================= Files 145 146 +1 Lines 16799 16441 -358 Branches 2075 2013 -62 ================================================= - Hits 11396 11185 -211 + Misses 5395 5248 -147 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ElJocko commented 9 months ago

Closes #306

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

25.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud