search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

294 refactor references service #331

Closed vsun757 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (4ad23ee) 67.68% compared to head (b937d43) 67.83%. Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/repository/references-repository.js 81.81% 20 Missing :warning:
app/services/references-service.js 84.00% 4 Missing :warning:
app/services/_base.service.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #331 +/- ## ================================================= + Coverage 67.68% 67.83% +0.15% ================================================= Files 144 145 +1 Lines 16788 16799 +11 Branches 2068 2075 +7 ================================================= + Hits 11363 11396 +33 + Misses 5417 5395 -22 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

4.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

ElJocko commented 9 months ago

Closes #294