search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored marking definitions service #336

Closed vsun757 closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (ab23273) 68.40% compared to head (dafc60b) 68.28%. Report is 1 commits behind head on project-orion.

:exclamation: Current head dafc60b differs from pull request most recent head 404efbd. Consider uploading reports for the commit 404efbd to get more accurate results

Files Patch % Lines
app/controllers/marking-definitions-controller.js 66.66% 17 Missing and 1 partial :warning:
app/services/marking-definitions-service.js 76.38% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #336 +/- ## ================================================= - Coverage 68.40% 68.28% -0.12% ================================================= Files 146 147 +1 Lines 15488 16341 +853 Branches 1837 2000 +163 ================================================= + Hits 10595 11159 +564 - Misses 4885 5173 +288 - Partials 8 9 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud