center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored data sources service for improved structure and asynchronicity #337

Closed vsun757 closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 205 lines in your changes are missing coverage. Please review.

Comparison is base (434003f) 68.25% compared to head (1125eab) 68.24%. Report is 66 commits behind head on project-orion.

Files Patch % Lines
app/services/data-sources-service.js 52.21% 54 Missing :warning:
app/controllers/techniques-controller.js 59.34% 37 Missing :warning:
app/controllers/data-sources-controller.js 63.41% 30 Missing :warning:
app/controllers/campaigns-controller.js 64.55% 28 Missing :warning:
app/repository/references-repository.js 81.98% 20 Missing :warning:
app/repository/user-accounts-repository.js 0.00% 14 Missing :warning:
app/services/techniques-service.js 85.18% 8 Missing :warning:
app/repository/_base.repository.js 64.70% 6 Missing :warning:
app/services/references-service.js 84.00% 4 Missing :warning:
app/services/collection-bundles-service.js 83.33% 3 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #337 +/- ## ================================================= - Coverage 68.25% 68.24% -0.01% ================================================= Files 145 146 +1 Lines 15997 15737 -260 Branches 1936 1887 -49 ================================================= - Hits 10918 10740 -178 + Misses 5071 4989 -82 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud