search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
42 stars 22 forks source link

Refactored Software service #339

Closed vsun757 closed 9 months ago

sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 9 months ago

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (6dd836e) 68.84% compared to head (d721767) 69.09%. Report is 2 commits behind head on project-orion.

Files Patch % Lines
app/controllers/software-controller.js 52.00% 60 Missing :warning:
app/services/software-service.js 90.16% 4 Missing and 2 partials :warning:
app/services/attack-objects-service.js 62.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #339 +/- ## ================================================= + Coverage 68.84% 69.09% +0.25% ================================================= Files 148 149 +1 Lines 15058 14777 -281 Branches 1767 1713 -54 ================================================= - Hits 10366 10210 -156 + Misses 4683 4556 -127 - Partials 9 11 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.