search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored identities service for improved structure and asynchronicity #342

Closed vsun757 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (d721767) 69.09% compared to head (61b0864) 69.07%. Report is 1 commits behind head on project-orion.

:exclamation: Current head 61b0864 differs from pull request most recent head 311bfba. Consider uploading reports for the commit 311bfba to get more accurate results

Files Patch % Lines
app/services/identities-service.js 59.92% 109 Missing :warning:
app/controllers/identities-controller.js 53.06% 46 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #342 +/- ## ================================================= - Coverage 69.09% 69.07% -0.02% ================================================= Files 149 150 +1 Lines 14777 14708 -69 Branches 1713 1700 -13 ================================================= - Hits 10210 10160 -50 + Misses 4556 4537 -19 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 7 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud