center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactor attack objects service for improved structure and asynchronicity #343

Closed vsun757 closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (ca9e552) to head (914a510). Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/attack-objects-service.js 69.64% 17 Missing :warning:
app/repository/attack-objects-repository.js 95.83% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #343 +/- ## ================================================= + Coverage 70.20% 70.26% +0.05% ================================================= Files 150 151 +1 Lines 14393 14365 -28 Branches 1671 1667 -4 ================================================= - Hits 10105 10093 -12 + Misses 4278 4262 -16 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
31.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud