search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
42 stars 22 forks source link

Refactor useraccounts service for improved structure and asynchronicity #344

Closed vsun757 closed 8 months ago

sonarcloud[bot] commented 8 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
29.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 8 months ago

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (311bfba) 69.46% compared to head (ca9e552) 70.20%. Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/user-accounts-service.js 60.20% 76 Missing :warning:
app/repository/user-accounts-repository.js 60.40% 59 Missing :warning:
app/controllers/user-accounts-controller.js 47.27% 29 Missing :warning:
app/services/teams-service.js 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #344 +/- ## ================================================= + Coverage 69.46% 70.20% +0.74% ================================================= Files 150 150 Lines 14496 14393 -103 Branches 1665 1671 +6 ================================================= + Hits 10069 10105 +36 + Misses 4416 4278 -138 + Partials 11 10 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.