search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactoring collections service #345

Open vsun757 opened 6 months ago

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 6 months ago

Codecov Report

Attention: 201 lines in your changes are missing coverage. Please review.

Comparison is base (4ad23ee) 67.68% compared to head (d90d733) 70.03%. Report is 222 commits behind head on project-orion.

Files Patch % Lines
app/services/collections-service.js 51.41% 172 Missing :warning:
app/controllers/collections-controller.js 46.29% 29 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #345 +/- ## ================================================= + Coverage 67.68% 70.03% +2.34% ================================================= Files 144 151 +7 Lines 16788 14350 -2438 Branches 2068 1660 -408 ================================================= - Hits 11363 10050 -1313 + Misses 5417 4290 -1127 - Partials 8 10 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.