center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored system configuration service for improved structure and asynchronicity #346

Closed vsun757 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 82.22222% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.50%. Comparing base (7f3178d) to head (53ee9c6). Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/system-configuration-service.js 80.76% 10 Missing :warning:
app/exceptions/index.js 81.39% 8 Missing :warning:
app/lib/database-configuration.js 50.00% 3 Missing :warning:
app/repository/system-configurations-repository.js 91.17% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #346 +/- ## ================================================= + Coverage 70.39% 70.50% +0.11% ================================================= Files 151 152 +1 Lines 14373 14445 +72 Branches 1660 1674 +14 ================================================= + Hits 10118 10185 +67 - Misses 4245 4250 +5 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud