center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Refactored collection indexes service for improved structure and asynchronicity #347

Open vsun757 opened 6 months ago

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 61.83746% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 70.43%. Comparing base (ca9e552) to head (aad6dd4). Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/repository/collection-index-repository.js 57.05% 67 Missing :warning:
app/controllers/collection-indexes-controller.js 50.68% 36 Missing :warning:
app/services/collection-indexes-service.js 90.74% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## project-orion #347 +/- ## ================================================= + Coverage 70.20% 70.43% +0.22% ================================================= Files 150 151 +1 Lines 14393 14417 +24 Branches 1671 1667 -4 ================================================= + Hits 10105 10154 +49 + Misses 4278 4253 -25 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.