search

center-for-threat-informed-defense / attack-workbench-rest-api

An application allowing users to explore, create, annotate, and share extensions of the MITRE ATT&CK® knowledge base. This repository contains the REST API service for storing, querying, and editing ATT&CK objects.
https://ctid.mitre-engenuity.org/
Apache License 2.0
40 stars 22 forks source link

Bug fix: duplicate names in matrix tactics #350

Closed clemiller closed 3 months ago

clemiller commented 3 months ago

Fixes an issue with retrieving tactics and techniques within a matrix when it contains tactics with duplicate names.

The matrix service builds the matrix by tactic, sequentially retrieving each tactic object and its techniques, and then maps the tactics by name (rather than by a unique ID). This causes subsequent tactics to be re-mapped/overwrite previous tactics with the same name and the matrix does not build as expected on the front end (appearing to have missing tactics/techniques).

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (1c28982) to head (60700c7).

Files Patch % Lines
app/services/matrices-service.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #350 +/- ## ======================================== Coverage 67.48% 67.48% ======================================== Files 130 130 Lines 17596 17596 Branches 2260 2260 ======================================== Hits 11875 11875 Misses 5713 5713 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.