search

center-for-threat-informed-defense / caldera_pathfinder

Pathfinder is a plugin for mapping network vulnerabilities, scanned by CALDERA or imported by a supported network scanner, and translating those scans into adversaries for network traversal.
https://caldera.mitre.org/
Apache License 2.0
120 stars 26 forks source link

V2 Getters and Setters #52

Closed heatonk closed 1 year ago

heatonk commented 2 years ago

Adds getters and setters for vulnerability reports, the hosts, and the hosts' attributes.

Not breaking code

CDJellen commented 2 years ago

The method-level changes look great, still two issues to resolve before this PR can be fully reviewed and merged:

  1. The spacing issue in c_host.py and elsewhere is still present (appears to be 8 spaces rather than 4),
  2. Prior commits to pathfinder-v2 are causing merge conflicts, please merge the latest from pathfinder-v2 into this branch,
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information