Closed emeth1 closed 9 months ago
@emeth1 Something is amiss with this branch. It has 80 commits going back to September. I think it needs to be rebased (probably to 3b1b1e375aa17a525293aede7f1d1a5ee18095cd). Let me know if you have any questions about fixing the branch.
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
The matrix view looks great! I wanted to note a few minor issues. We can fix these in future jira tickets.
One last nit on these dropdowns: they don't change the URL, so if somebody selects a different version and then wants to send the URL to somebody else, they'll accidentally copy the wrong URL. We should either use the dropdowns to navigate to another page, or else use pushState
to modify the URL.
The matrix view looks great! I wanted to note a few minor issues. We can fix these in future jira tickets.
- The "See mappings" button doesn't seem to do anything. The matrix reloads as soon as I select a new version, so the button seems unneccessary. But if I do click the button it takes me back to the original page I was on.
One last nit on these dropdowns: they don't change the URL, so if somebody selects a different version and then wants to send the URL to somebody else, they'll accidentally copy the wrong URL. We should either use the dropdowns to navigate to another page, or else use
pushState
to modify the URL.
- The tooltip that pops up occasionally pops up on top of the technique, which causes it to kind of flicker on and off.
- When I click "Show all sub-techniques", some of the boxes that don't have subtechniques get a little bit of geometry next to them that's not supposed to be there.
For the See Mappings button: I like the fact that the dropdowns change the view automatically with no need to press an extra button. However, the See Mappings button is consistent with other pages. Do you have an opinion whether or not to use the See Mappings button?
For the See Mappings button: I like the fact that the dropdowns change the view automatically with no need to press an extra button. However, the See Mappings button is consistent with other pages. Do you have an opinion whether or not to use the See Mappings button?
I also like how it changes immediately, and it's okay if that's not how the other pages work. Let's lose the button.
But I do want the URL to update, so I think pushState is the way to go, because it will change the URL without forcing a page load.
I fixed the tooltips, removed the see mappings button, and added docstrings. The following two items I will add to another ticket:
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-42_initial_matrix_view/
Fixes #42
What Changed
Known Limitations
@cache
works properly inattack_query