Closed emeth1 closed 4 months ago
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
Looks good. @emeth1 please review the merge conflicts.
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
Attention: 28 lines
in your changes are missing coverage. Please review.
Comparison is base (
c99215d
) 23.09% compared to head (c8a4076
) 23.62%.
Files | Patch % | Lines |
---|---|---|
src/mapex/write_parsed_mappings.py | 51.21% | 20 Missing :warning: |
src/mapex/cli.py | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-162_cli_updates_for_editor_compatibility/
What changed
attack_version
andtechnology_domain
added to JSON schema but removed from exportsjson
export is done correctly instead of copying