center-for-threat-informed-defense / mappings-explorer

Mappings Explorer enables cyber defenders to understand how security controls and capabilities map onto the adversary behaviors catalogued in the MITRE ATT&CK® knowledge base. These mappings form a bridge between the threat-informed approach to cybersecurity and the traditional security controls perspective.

https://ctid.io/mappings-explorer

Apache License 2.0

25 stars 6 forks source link

MAPEX-178: fix veris bugs #83

Closed emeth1 closed 4 months ago

emeth1 commented 4 months ago

What changed

veris counts on all mappings match
all techniques from all domains build correctly
capability groups and capabilities with no mappings not in capability groups / capabilities list
capabilities with no mappings not added to total mappings count
non_mappable capability pages built only if the project has non_mappable comments

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 22.76%. Comparing base (39524b7) to head (156be25).

Files	Patch %	Lines
src/mappings_explorer/site_builder.py	0.00%	45 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================== - Coverage 23.11% 22.76% -0.36% ========================================== Files 11 11 Lines 1484 1507 +23 ========================================== Hits 343 343 - Misses 1141 1164 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-178_fix_veris_mismatch_counts/

tiffb commented 4 months ago

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments.

github-actions[bot] commented 4 months ago

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-178_fix_veris_mismatch_counts/

emeth1 commented 4 months ago

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments.

I don't think it rebuild yet when you checked. Can you check again now and confirm whether or not you see the correct non mappable table? Thanks.

tiffb commented 4 months ago

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments.

I don't think it rebuild yet when you checked. Can you check again now and confirm whether or not you see the correct non mappable table? Thanks.

I'm seeing the correct tables & pages - looks good! thank you