Closed allisonrobbins closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 23.17%. Comparing base (
52a13e3
) to head (cfea5c5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
Hold on merging (request from @mikecarenzo)
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
@allisonrobbins @mikecarenzo are still holding off, or is this ready to merge?
@mehaase Still holding, I just need to compile a proper .ico
file that dynamically sizes and changes color based on context (light vs. dark-theme browsers). The favicon is used for more than just the icon on the tab. It's also used for bookmarks, shortcuts, home-screen icons, etc. The current icon will appear very blurry in all these contexts without a proper .ico
file. I should have one prepared shortly.
OK, I'll move this back to draft status.
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-186-Replace-Logo-in-Mappings-Explorer/
Replace CTID logo on site with new Mappings Explorer logo
Also fixed unmappables bug here instead of opening a new ticket