MAPEX-150 Optimize large files

center-for-threat-informed-defense / mappings-explorer

Mappings Explorer enables cyber defenders to understand how security controls and capabilities map onto the adversary behaviors catalogued in the MITRE ATT&CK® knowledge base. These mappings form a bridge between the threat-informed approach to cybersecurity and the traditional security controls perspective.

https://ctid.io/mappings-explorer

Apache License 2.0

25 stars 6 forks source link

MAPEX-150 Optimize large files #93

Closed mehaase closed 3 months ago

mehaase commented 3 months ago

If a mappings table has over 500 rows, we now truncate to 500 rows, show a message, and link to the full size file. This improves initial page load, expecially for NIST page which is the first on featured on the home page and is our most popular project.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 22.90%. Comparing base (78f0237) to head (8b64da2).

Files	Patch %	Lines
src/mappings_explorer/template.py	0.00%	11 Missing :warning:
src/mappings_explorer/site_builder.py	0.00%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== - Coverage 23.17% 22.90% -0.28% ========================================== Files 11 11 Lines 1506 1524 +18 ========================================== Hits 349 349 - Misses 1157 1175 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/

mehaase commented 3 months ago

@tiffb can you take a quick look at this? Here's an example, this page was 3MB before and is now 300KB. https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/external/nist/

tiffb commented 3 months ago

@mehaase "All Mappings" table is not appearing for Azure (https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/external/azure/):

mehaase commented 3 months ago

Azure "All Mappings" table is not loading.

Can you try refreshing? I am seeing it when I click that link.