search

centerclick / feedback

Issues, Bug Reports, and Feature Requests
7 stars 0 forks source link

Filter client list to not include blocked IP's #5

Closed sgrayban closed 2 years ago

sgrayban commented 2 years ago

Or someway to exclude them in the list or sort the list between allowed and blocked IP's

dave4445 commented 2 years ago

The NTP Client list includes all clients including those that are blocked due to ACL configuration. This is due to clients being monitored prior to ACL processing.

Agree, It would be better to flag these somehow or exclude them from the list.

dave4445 commented 2 years ago

Next release will have:

while not excluding blocked clients, this will easially show that they are being blocked and/or rate limited. Rate limited clients with yellow warning, and blocked clients with a red X.

work in progress:

image

dave4445 commented 2 years ago

released 1.21

srob1 commented 2 years ago

Blocked client not being flagged with red X as described above: image

dave4445 commented 2 years ago

Give it a bit longer... minimum of 10 blocked packets until it's flagged

  if ((entry->cnt[DIRECTION_RX] >= 10) && !entry->cnt[DIRECTION_TX])
    {
      color = ALERT_RED;
    }
srob1 commented 2 years ago

The Client JSON indicates there is no alert for the blocked client: { "10.10.10.164":{"first":{"ago":"562 sec ago","utc":1634061341,"when":"2021-10-12 17:55:41 UTC"},"last":{"ago":"561 sec ago","utc":1634061342,"when":"2021-10-12 17:55:42 UTC"},"rx freq":0.5,"rx count":2,"tx count":0,"alert":null} }

srob1 commented 2 years ago

Ahh, ok. Sorry.

From: Dave @.> Sent: Tuesday, October 12, 2021 2:06 PM To: centerclick/feedback @.> Cc: srob1 @.>; Comment @.> Subject: Re: [centerclick/feedback] Filter client list to not include blocked IP's (#5)

Give it a bit longer...

if ((entry->cnt[DIRECTION_RX] >= 10) && !entry->cnt[DIRECTION_TX])

{

  color = ALERT_RED;

}

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/centerclick/feedback/issues/5#issuecomment-941248051, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHTTACEXYT3WPELHEZP3O2TUGR2JBANCNFSM5DYB43PA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sgrayban commented 2 years ago

What is the yellow triangle icon?

dave4445 commented 2 years ago

either of the following conditions:

tx>0 and ratio of rx/tx >= 5 this indicates large amounts of drops or rate limits or rx>=10 and rx_freq < 6 seconds this indicates consistent frequent requests