centraldedados / datacentral

Tools for generating portable data portals
58 stars 9 forks source link

Fixed padding right of search box #16

Closed metaodi closed 9 years ago

metaodi commented 9 years ago

Because of the huge padding right and the width: 100% the search box overlaped the list of datasets. With this fix the page looks okayish again.

I personally think the search is very important and therefore should not only be in the sidebar. Has there been a discussion about this?

aiscarvalho commented 9 years ago

Good question! At the moment, the search box placement is based in our specific use case and needs. So far we have very few datasets published at Central de Dados so it didn't make sense to make the search highly prominent. Of course this will change over time and by then we'll change it accordingly.

Neverthelesss, we're working on a more general theme and for that one the search will be placed differently!

rlafuente commented 9 years ago

Indeed, having a generic theme is a logical next step, so that people won't have to deal with Portuguese text if they want to use Datacentral. From there we can determine what should go where and for what purpose. But feel free to experiment and see what comes up!

On 11/28/2014 01:04 PM, Ana Isabel Carvalho wrote:

Good question! At the moment, the search box placement is based in our specific use case and needs. So far we have very few datasets published at Central de Dados http://centraldedados.pt so it didn't make sense to make the search highly prominent. Of course this will change over time and by then we'll change it accordingly.

Neverthelesss, we're working on a more general theme and for that one the search will be placed differently!

— Reply to this email directly or view it on GitHub https://github.com/centraldedados/datacentral/pull/16#issuecomment-64891811.

rlafuente commented 9 years ago

Just noticed that we hadn't merged this one -- thanks so much :-)