search

centralnicgroup-opensource / rtldev-middleware-whmcs-rrpproxy-registrar

RRPproxy Registrar Module for WHMCS
https://www.rrpproxy.net
MIT License
7 stars 5 forks source link

Fix typo in updateContact method #27

Closed RevZer0 closed 3 years ago

RevZer0 commented 3 years ago

Fix access to $contactDetails['Address'] parameter while preparing payload for updating/adding contact.

KaiSchwarz-cnic commented 3 years ago

@RevZer0 thanks for reporting, it will be handled by @h9k. For future cases, please consider these rules for commit messages: https://www.conventionalcommits.org/en/v1.0.0/#summary

It is documented in our Development Guide.

If possible, please reword your commit message - otherwise @h9k will do that in this case.

RevZer0 commented 3 years ago

I did git commit --amend and force push as it said in github documentation Do I did wrong?

KaiSchwarz-cnic commented 3 years ago

no, that's fine too. we use that interactive rebasing approach which allows also squashing, dropping etc. of branch commits. ty @RevZer0.

h9k commented 3 years ago

@RevZer0 I can confirm this is an issue. Thanks for the pull request!

h9k commented 3 years ago

:tada: This PR is included in version 0.4.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: