feat(getdomaininformation): extended to also return addon status

centralnicgroup-opensource / rtldev-middleware-whmcs-rrpproxy-registrar

RRPproxy Registrar Module for WHMCS

https://www.rrpproxy.net

MIT License

7 stars 5 forks source link

feat(getdomaininformation): extended to also return addon status #41

Closed KaiSchwarz-cnic closed 3 years ago

KaiSchwarz-cnic commented 3 years ago

Hi @h9k,

please review & test my extension of GetDomainInformation. The idea behind is to have this information available for the Domain Import Addon I am currently working on for RRP/HX. Allowing us to write a more generic code base there.

I removed a try catch block as it was nested in a try catch doing exactly the same, superfluous imho. If I am wrong with that, let me know.

ty!

h9k commented 3 years ago

I experienced an exception in my OT&E, so I improved the handling of the CheckDNSZone command. All looks good now!

KaiSchwarz-cnic commented 3 years ago

:tada: This PR is included in version 0.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: