search

centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
40 stars 15 forks source link

Disable auto renew from admin interface doesn't cancel the invoice #166

Closed DennisSkov closed 3 years ago

DennisSkov commented 3 years ago

Describe the bug Disabling auto-renew from WHMCS admin doesn't cancel active invoice.

To Reproduce Steps to reproduce the behavior:

  1. Make sure there's an active invoice for the domain
  2. Disable automatic renewal for the domain from the admin interface
  3. Invoice is still active

Expected behavior When the client disables auto renew from the client area, the invoice is cancelled. If the domain renewal is part of an invoice with multiple items, the domain item is removed from the invoice.

Unfortunately, we've just handed our client a free renewal because of this - I was not aware that WHMCS doesn't automatically cancel invoices when auto renew is disabled from the admin interface. I'm not surprised, though 😅 Would it be possible to work around this somehow?

KaiSchwarz-cnic commented 3 years ago

Hi @DennisSkov !

TBH, this doesn't sound like an issue of our provider plugin. None of your provided steps has a process bound to a registrar module function call. Our possibilities === 0 :-(

I guess, reporting this as bug of WHMCS Core at whmcs.com is worth it. But, I have my doubts if they are willed to review there.

The only idea I can forward to you, is to check if there's a hook available that is invoked immediately after disabling the automatic renewal and then to apply your custom logic there.

Sorry that I can't provide there more information and better news. Therefore closing. If I've missed something, feel free to follow-up - we are always open for a detailed discussion :-)