centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
40 stars 15 forks source link

Cannot disable domain suggestions #199

Closed eMiz0rz closed 3 years ago

eMiz0rz commented 3 years ago

Ok for starters: I'm sure I must be doing something wrong but would like to have your idea's. I'm using WHMCS 7.10.3 and the newest release of the ispapi plugin.

Currently I have configured some TLD's to show on the domainchecker in the shoppingcart (domain=register page) under Product/Services > Domain pricing > Lookup provider (please see screenshot attached).

In this configuration, no extra TLD's are suggested in the shopping cart. The section (div class="suggested domains") is not being displayed as in hidden in the template. However when I enable "Suggestion Engine based on search term" not only extra TLD's are suggested, but also totally other domains. These suggestions are usually crap (nofi) and I only want to suggest other TLD's based on the same domain, not other domains.

It was my understanding that deselecting this option prevents the plugin from searching other domains (and instead only displays other TLD's), but maybe I have configured something wrong?

Could use some help! Schermafbeelding 2021-07-27 113219

KaiSchwarz-cnic commented 3 years ago

Hi @eMiz0rz,

thanks for forwarding. Up to now, no issues are known/reported to us. I'll check your findings and keep you posted. Could probably take until tomorrow.

Best Kai

eMiz0rz commented 3 years ago

Thanks for checking Kai!

Just to be sure I have tried the standard WHOIS in WHMCS as lookup provider and this works fully expected: it suggests different TLD's, but not different domains. But this WHOIS is very slow and pretty much a conversion killer compared to your WHOIS :)

Regards,

Maurice

KaiSchwarz-cnic commented 3 years ago

Np, you're always welcome.

Yes, the WHMCS native search is very slow, one reason why people choose our addon :-) Would you mind going this guide through, step by step in the meanwhile? I'll be busy today anyway. I'll start checking your issue tomorrow, I can't rethink into another topic earlier tbh :-)

If that guide is known to you, never mind then.

It could be that you have to cover that by our domain checker's own configuration section, so it is just an issue with bad alignment of our addon with the registrar module's lookup provider settings / domain name suggestion settings.

Cheers!

KaiSchwarz-cnic commented 3 years ago

Hi @eMiz0rz,

I checked your case - it works as expected. I am having the latest version of our ispapi registrar module & domain checker installed.

et voilà.

Finally, it is about finding the right solution on how to forward requests for domainchecker.php to mydomainchecker.php. There are basically 3 ways: By webserver configuration & using mod_rewrite. By .htaccess. or by replacing domainchecker.php with our file - this works but if you upgrade WHMCS, you'll have then to do that step again (an error prone process therefore).

Just in case you have still trouble, let me know.

HTH