centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
35 stars 15 forks source link

encoded files are reported as corrupt #231

Closed PhiGi87 closed 1 year ago

PhiGi87 commented 1 year ago

Hi, unfortunately I found a new bug and now I can't edit my domain prices anymore. Look here:

`Whoops\Exception\ErrorException: The encoded file /var/www/htdocs/whmcs/modules/registrars/ispapi/ispapi.php is corrupt. in Unknown:0 Stack trace:

0 /var/www/host-on/htdocs/whmcs/vendor/whmcs/whmcs-foundation/lib/Utility/Error/Run.php(0): WHMCS\Utility\Error\Run->handleError(16, '

The encoded...', 'Unknown', 0)

1 [internal function]: WHMCS\Utility\Error\Run->handleShutdown()

2 {main}`

KaiSchwarz-cnic commented 1 year ago

@PhiGi87 thanks, and sorry for the circumstances. Looks like either an issue of our encryption or eventually an incompatibility of our encryption with the loader in use on your end. We are already playing around with all that to figure the root cause out.

KaiSchwarz-cnic commented 1 year ago

https://github.com/centralnicgroup-opensource/rtldev-middleware-whmcs/releases/tag/v16.3.1

We played around with our encryption process and it looks like we run in a bug of ioncube encoder. We changed the order of the versions we encrypt with from higher to lower and it worked for us. We'll be reporting this also back to ioncube as their documentation isn't stating something out regarding the order being important. Sorry for the inconveniences caused, we'll be testing produced archives in future as well.

KaiSchwarz-cnic commented 1 year ago

Looks like the fix worked for us, but not for one of our resellers, keeping it open therefore for further analysis.

KaiSchwarz-cnic commented 1 year ago

One of our customer mentioned that after switching the ioncube loader for PHP from version 11 to 12 helped on his end. Can you ensure that you're using the latest loader version?

KaiSchwarz-cnic commented 1 year ago

We stopped using bundled encryption (ioncube user guide section 3.14) and are offering now standalone packages temporarily until those issues are patched. Still, please ensure that the latest loader version is installed and consumed by PHP.

https://github.com/centralnicgroup-opensource/rtldev-middleware-whmcs/releases/tag/v16.3.2

We have high priority tickets open at WHMCS and ioncube. We followed the ioncube guide by letter and it obviously didn't work. I'll keep this thread in the loop.

KaiSchwarz-cnic commented 1 year ago

@PhiGi87 (and anyone else having this problem): Do you mind sending the below to my hands via support ticket:

Thanks so much in advance!

Ioncube asked us to provide this information together with our encrypted + problematic file. Feedback also received from WHMCS and basically we used the right way of encrypting initially. From their point of view. Which sounds good. we just need to figure out where all this still comes from.

KaiSchwarz-cnic commented 1 year ago

We identified the issue and solved it. 16.3.4 released:

https://github.com/centralnicgroup-opensource/rtldev-middleware-whmcs/releases