search

centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
35 stars 15 forks source link

Aftermarket Domains Toggle #238

Closed an0nz closed 1 year ago

an0nz commented 1 year ago

Describe the bug Using ISPAPI v16.6.2 for Hexonet as the WHMCS Lookup Provider some Premium domains return results with a price rather than Unavailable.

To Reproduce Steps to reproduce the behavior:

  1. Set Lookup Provider to ISPAPI
  2. Go to Register Domain in WHMCs client area and search for hubforteams.com
  3. Result shows hubforteams.com as available along with a price

Expected behavior The domain should be unavailable and only exist for transfer

Context:

Relevant Logs:

COMMAND = CheckDomains
PREMIUMCHANNELS = *
DOMAIN0 = hubforteams.com

[RESPONSE]
PROPERTY[DOMAINCHECK][0]=211 NOT AVAILABLE
PROPERTY[PREMIUMCHANNEL][0]=AFTERNIC
PROPERTY[PRICE][0]=1200.00
COMMAND = CheckDomains
PREMIUMCHANNELS = *
DOMAIN0 = hubforteams.com
DOMAIN1 = hubforteams.net
DOMAIN2 = hubforteams.org
DOMAIN3 = hubforteams.biz
DOMAIN4 = hubforteams.info
DOMAIN5 = hubforteams.io

[RESPONSE]
CODE=200
PROPERTY[CURRENCY][0]=USD
PROPERTY[CURRENCY][1]=
PROPERTY[CURRENCY][2]=
PROPERTY[CURRENCY][3]=
PROPERTY[CURRENCY][4]=
PROPERTY[CURRENCY][5]=
PROPERTY[FINALIZATIONDATE][0]=
PROPERTY[FINALIZATIONDATE][1]=
PROPERTY[FINALIZATIONDATE][2]=
PROPERTY[FINALIZATIONDATE][3]=
PROPERTY[FINALIZATIONDATE][4]=
PROPERTY[FINALIZATIONDATE][5]=
PROPERTY[REASON][0]=Domain exists
PROPERTY[REASON][1]=Domain exists
PROPERTY[REASON][2]=
PROPERTY[REASON][3]=
PROPERTY[REASON][4]=
PROPERTY[REASON][5]=
PROPERTY[PRICE][0]=1200.00
PROPERTY[PRICE][1]=
PROPERTY[PRICE][2]=
PROPERTY[PRICE][3]=
PROPERTY[PRICE][4]=
PROPERTY[PRICE][5]=
PROPERTY[CLASS][0]=
PROPERTY[CLASS][1]=
PROPERTY[CLASS][2]=
PROPERTY[CLASS][3]=
PROPERTY[CLASS][4]=
PROPERTY[CLASS][5]=
PROPERTY[DOMAINCHECK][0]=211 NOT AVAILABLE
PROPERTY[DOMAINCHECK][1]=211 NOT AVAILABLE
PROPERTY[DOMAINCHECK][2]=210 Available
PROPERTY[DOMAINCHECK][3]=210 Available
PROPERTY[DOMAINCHECK][4]=210 Available
PROPERTY[DOMAINCHECK][5]=210 Available
PROPERTY[PREMIUMCHANNEL][0]=AFTERNIC
PROPERTY[PREMIUMCHANNEL][1]=
PROPERTY[PREMIUMCHANNEL][2]=
PROPERTY[PREMIUMCHANNEL][3]=
PROPERTY[PREMIUMCHANNEL][4]=
PROPERTY[PREMIUMCHANNEL][5]=
PROPERTY[DOMAINCHECKTIME][0]=0.326
PROPERTY[DOMAINCHECKTIME][1]=0.377
PROPERTY[DOMAINCHECKTIME][2]=0.186
PROPERTY[DOMAINCHECKTIME][3]=0.191
PROPERTY[DOMAINCHECKTIME][4]=0.177
PROPERTY[DOMAINCHECKTIME][5]=0.177
QUEUETIME=0
DESCRIPTION=Command completed successfully
RUNTIME=0.502

QUEUETIME=0
RUNTIME=0.598

EOF
an0nz commented 1 year ago

The domain correctly displays as Taken and Transfer when using mydomainchecker.php but does not for WHMC's built in domain registration / search page

KaiSchwarz-cnic commented 1 year ago

@an0nz thanks for forwarding. Let me dive into analysis.

KaiSchwarz-cnic commented 1 year ago

Hmm... this is basically a feature of our ispapi integration. It is a aftermarket domain name (e.g. hubforteams.com) that your clients could buy that way. Transfers are still working - go to the Transfer Form, input the domain + epp code - voila, you're able to add it to shopping cart.

@an0nz isn't this useful? The domain is getting actively offered via afternic.com and is therefore "available". Would you prefer having a possibility to toggle that behavior on/off? Something like a Registrar Module Setting that is by default turned off (aftermarket domains not supported) and when turned on, aftermarket domains are supported.

The domains in question aren't real premium domains, that's just how we cover aftermarket domains on API Level. In WHMCS we "abuse" the premium domain feature to cover aftermarket domain names. After ordering and getting them onto the account, they are getting switched back to regular domains.

Thanks for sharing your opinion

Best Kai

KaiSchwarz-cnic commented 1 year ago

I just noticed a pricing issue that will be patched tomorrow and if you're interested in that Toggle, I could include it as well.

an0nz commented 1 year ago

@KaiSchwarz-cnic that would be a useful toggle. This is causing issues for us as we use the Domains Extended addon, its Domain Transfer uses the search to identify if a domain can be transferred or registered on the same page.

KaiSchwarz-cnic commented 1 year ago

v16.6.5 is out, patching the aftermarket pricing I noticed plus some issues with PHP8.

@an0nz will have an eye on that toggle. thanks for addressing.

KaiSchwarz-cnic commented 1 year ago

Find the toggle release via v16.7.0 plus some aftermarket related patches.

HTH / Enjoy your day