centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
35 stars 15 forks source link

TLD Import & Pricing Sync - grace period price wrongly set #248

Closed Remitur closed 1 year ago

Remitur commented 1 year ago

Describe the bug Using TLD Import & Pricing Sync ( /admin/utilities/tools/tldsync/import ) grce period fee is wrongly set. According to WHMCS, grace fee renewal and redemption fee renewal are sums that will be added to ordinary renewal fee. So, i.e.:

Instead, in your price schema grace period renewal fee and redemption period renewal fee include also standard renewal fee.

So, i.e., currently in /admin/utilities/tools/tldsync/import your costs are reported so: register 10 renew 10 transfer 10 grace 10 redemption 90

Instead should be:

register 10 renew 10 transfer 10 grace 0 redemption 80 (that's to say, 90-10)

KaiSchwarz-cnic commented 1 year ago

@Remitur ispapi or cnic? or both?

Remitur commented 1 year ago

For sure cnic (not already checked for ispapi, but I guess also ispapi is affected)

KaiSchwarz-cnic commented 1 year ago

Thanks @Remitur for such bug reports. Very much appreciated. -> v17.0.9