Closed AndyAlvarezDev closed 1 year ago
@AndyAlvarezDev
thanks for forwarding, let us have an eye on it.
@AndyAlvarezDev
do you mind providing your exact search? it is working fine for us if we try with e.g. coffee
or coffeeshop12313131.com
.
Also, in table tblerrorlog, you may find related error details that would be great to have at hand :-) Thanks for sharing, if there's something useful in there.
The error occurs both ways, if I search for "testing" or "testing.com" (example)
`51 error Error Call to a member function getStatus() on string vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/Registrar.php 0 #0 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/AbstractProvider.php(0): WHMCS\Domains\DomainLookup\Provider\Registrar->getGeneralAvailability()
That is the error generated in the table "tblerrorlog"
As I said before that only happens with CentralNic, with the Hexonet it works perfectly
Thanks Andy for reporting. Should be patched in v17.1.1.
The error continues in version 17.1.1
Call to a member function getStatus() on string
vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/Registrar.php
`#0 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/AbstractProvider.php(0): WHMCS\Domains\DomainLookup\Provider\Registrar->getGeneralAvailability()
Can you reproduce this error? I have tried it in a new installation of whmcs and the error continues...
As I said before it only happens with CentralNicReseller, with Hexonet it works normally.
mhmm! let me dive again into this one... Do you mind sharing your Lookup Provider Settings? The PHP Error is triggered by WHMCS and the backtrace isn't that helpful - just giving a hint that is obviously related to the status.
I am not able getting this ad-hoc reproduced. I connected now also to the live system, but works there as well. Looks like I need a bit more input (whois provider settings).
Hi @AndyAlvarezDev
my team mate @AsifNawaz-cnic was able getting this reproduced under PHP 7.3. it works fine for PHP 7.4 and above. Does that help?
Hi @KaiSchwarz-cnic
That doesn't help, I'm using php version 8.1.18
Hi @AndyAlvarezDev,
I apologize for any confusion earlier. Upon further analysis, it appears that the issue is not related to PHP 7.3. Instead, it seems to be related to the domain lookup provider. Please note that WHMCS has an integrated registrar module called CentralNic Reseller. It's possible that you may have accidentally selected this option instead of our custom CentralNic Reseller.
To resolve this issue, please ensure that you select the correct CentralNic Reseller option that includes a version number. This should help resolve the issue you are experiencing.
I am a dev, I have nothing wrongly configured and as I said before, that only happens with CentralNic. If it were my mistake, it would happen with another registrar, even with Hexonet and it works fine with all of them...
Hi @AsifNawaz-cnic
I've tried it in a new installation too, I can't see the code because it's coded with ioncube, but I think the problem is related to "Premium Domains" I have it disabled, but apparently it takes it as if the button was active, I think It's related to that...
But it's not an internal whmcs problem because it only occurs with CentralNic Reseller
Hey Andy,
I can reproduce this in case I am just having our CentralNic Reseller Registrar Module activated, but no inputs made / not configured or wrongly configured. Can you check the Registrar Module Settings for us as well? ... and if you don't mind submitting them again to ensure they are correctly saved again and then to retry?
Also the Module Log might provide Details related to the CheckDomains call - do you mind sharing it?
thanks
Module configuration:
Generated PHP log:
/home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/AbstractProxyMiddleware.php(0): Middlewares\\Utils\\Delegate->process() #13 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\AbstractProxyMiddleware->_process() #14 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\AbstractProxyMiddleware->process() #15 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #16 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #17 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/AbstractProxyMiddleware.php(0): Middlewares\\Utils\\Delegate->process() #18 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\AbstractProxyMiddleware->_process() #19 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\AbstractProxyMiddleware->process() #20 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #21 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #22 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/BackendPsr7Response.php(0): Middlewares\\Utils\\Delegate->process() #23 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/BackendPsr7Response.php(0): unknown() #24 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/BackendPsr7Response.php(0): WHMCS\\Route\\Middleware\\BackendPsr7Response->_process() #25 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\BackendPsr7Response->process() #26 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #27 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #28 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(56): Middlewares\\Utils\\Delegate->process() #29 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/BackendDispatch.php(0): Middlewares\\Utils\\Dispatcher->dispatch() #30 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\BackendDispatch->_process() #31 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\BackendDispatch->process() #32 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #33 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #34 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutePathMatch.php(0): Middlewares\\Utils\\Delegate->process() #35 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\RoutePathMatch->_process() #36 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\RoutePathMatch->process() #37 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #38 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #39 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/WhitelistFilter.php(0): Middlewares\\Utils\\Delegate->process() #40 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/DelegatingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\WhitelistFilter->_process() #41 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\WhitelistFilter->process() #42 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #43 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #44 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutableClientModuleRequest.php(0): Middlewares\\Utils\\Delegate->process() #45 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\RoutableClientModuleRequest->_process() #46 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\RoutableClientModuleRequest->process() #47 [internal function]: Middle
[Tue May 09 17:46:24.621339 2023] [fcgid:warn] [pid 268252:tid 139708609844992] mod_fcgid: stderr: ic_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutableAdminRequestUri.php(0): Middlewares\\Utils\\Delegate->process() #50 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\RoutableAdminRequestUri->_process() #51 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\RoutableAdminRequestUri->process() #52 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #53 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #54 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutableRequestUri.php(0): Middlewares\\Utils\\Delegate->process() #55 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutableRequestUri.php(0): unknown() #56 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\RoutableRequestUri->_process() #57 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\RoutableRequestUri->process() #58 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #59 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #60 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/RoutableRequestQueryUri.php(0): Middlewares\\Utils\\Delegate->process() #61 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Route/Middleware/Strategy/AssumingMiddlewareTrait.php(0): WHMCS\\Route\\Middleware\\RoutableRequestQueryUri->_process() #62 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(76): WHMCS\\Route\\Middleware\\RoutableRequestQueryUri->process() #63 [internal function]: Middlewares\\Utils\\Dispatcher->Middlewares\\Utils\\{closure}() #64 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Delegate.php(31): call_user_func() #65 /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/middlewares/utils/src/Dispatcher.php(56): Middlewares\\Utils\\Delegate->process() #66 /home/testing.org/domains/whm.dev.testing.org/public_html/index.php(0): Middlewares\\Utils\\Dispatcher->dispatch() #67 {main} {"exception":"[object] (Error(code: 0): Call to a member function getStatus() on string at /home/testing.org/domains/whm.dev.testing.org/public_html/vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/Registrar.php:0)"} [], referer: https://whm.dev.testing.org/
In "tblerrorlog" it basically boils down to the same thing
@AndyAlvarezDev please check the Module Log, for related entries to CheckDomains. System Logs > Module Log
We identified how to patch and avoid HTTP 500 case and that ugly error being thrown. Still, the exact reason why it fails is related to the API response of CheckDomains.
OT&E Environment:
LIVE Environment:
Thanks @AndyAlvarezDev. Very helpful. In the OT&E Case, looks like you haven't activated zone/tld .com at least. CNR comes with a big difference: Even though prices are assigned/configured, TLDs/Zones have to be activated in the Web Interface/Control Panel. I suggest checking that.
The Live System case is something I'll have to clarify. That error is yet unknown to me. We'll also have an eye on your hint related to the premium domains toggle. Thanks for addressing.
@AndyAlvarezDev Regarding the Live System: Looks like your account has still status "PENDING" - incomplete set up. I've addressed this to our Sales Department. That's why you're receiving that Authorization failed error there.
So, regarding the issue of CheckAvailability
and GetDomainSuggstions
, we identified the issue where it came originally from:
https://github.com/WHMCS/sample-registrar-module/issues/13 https://github.com/WHMCS/sample-registrar-module/issues/8
We were following the integration example of CheckAvailability and of GetDomainSuggestions. In both examples, you see they return an error in case of a thrown Exception which is incorrect as WHMCS expects type \WHMCS\Domains\DomainLookup\ResultsList.
We rolled out v17.1.4 including the review of all that.
Premium Domain Toggle -> Still WIP/in Analysis. I'll keep this thread updated.
@AndyAlvarezDev I tested the Premium Domain Toggle -> works fine. You can identify this in the Module Log:
If Premium Domains are turned on, Command CheckDomains includes those X-FEE-*
parameters otherwise not.
HTH / Enjoy your day!
@AndyAlvarezDev fyi: Sales Department (Jaume) activated .com for you in OT&E.
WHMCS: 8.7.2 Module: Using the CentralNic Reseller v17.0.13 module does not search for domains correctly
Observation: with ISPAPI v17.0.13 (hexonet) it works normally, the problem is only with CentralNic Reseller