search

centre-for-educational-technology / EzTest

:pencil: Lightweight student testing system compatible with IMS QTI
MIT License
1 stars 0 forks source link

Browser side login form validation #4

Open pjotrsavitski opened 8 years ago

pjotrsavitski commented 8 years ago

The default browser side login form validation should be disabled and replaced with some general system specific own validation.

This way validation visuals could be controlled and would become consistent in all the browsers.

Later on it would also allow to make these translatable, if the system will ever get that capability.

This belongs to the context of a container issue #2

pjotrsavitski commented 8 years ago

@vtomberg Please comment on need to have own validation. It should be consistent throughout the system and should be applicable in context of every form (or not).

vtomberg commented 8 years ago

Did not get the question completely. What means: "general system specific own validation"? Is that some kind of user interface approach, or the server-side logic? Could you, please, provide some examples?

pjotrsavitski commented 8 years ago

This means that we allow file upload and only check it after, before moving to own storage. If file is too large, then remove it and respond with error.

This one has a discussion on it (could not find anything better fast): https://github.com/felixge/node-formidable/issues/324

vtomberg commented 8 years ago

Let us discuss this issue in person

pjotrsavitski commented 8 years ago

Agree, previous comment was for the wrong issue.

This validation could be something BnP does, adding state (changes colour) and showing an error explanation message underneath. Something like that, logic wise.