search

centre-for-effective-altruism / givingwhatwecan-org-static

Static build for Giving What We Can (givingwhatwecan.org) using Metalsmith and Netlify
5 stars 0 forks source link

Refactor stats to work with EA.org #54

Closed colophonemes closed 5 years ago

jpaddison3 commented 5 years ago

Invalid rank_by_pledge_type?

jpaddison3 commented 5 years ago

I was also getting a "Our ... members have..." (first ellipsis literal) which I may have mentioned to you and is what caused me to assign the review to you

jpaddison3 commented 5 years ago

Stats seem to be calculating correctly, but displaying wrong.

jpaddison3 commented 5 years ago

Members list looks good

colophonemes commented 5 years ago

Stats seem to be calculating correctly, but displaying wrong.

Screenshot? Is this the issue where the member count on the frontpage is ... and if you look at the code for that element, it says 'data-numbermembers=0`? If so, that's a definite bug. If not, then I'll need to do more digging.

jpaddison3 commented 5 years ago

image

jpaddison3 commented 5 years ago

<span class="number numberMembers" data-number="1" id="amazing-thing-number-0">...</span>

colophonemes commented 5 years ago

Can you try adding a couple more GWWC members to your DB? It works fine for me, I suspect the issue is something like the rolling-numbers animation starting at 1, but then there's only 1 member to get to, so it never gets going.