expose mgm parameters to control MINDIFF and LRRL filter behavior - Githubissues

centreborelli / s2p

Satellite Stereo Pipeline

GNU Affero General Public License v3.0

209 stars 67 forks source link

expose mgm parameters to control MINDIFF and LRRL filter behavior #100

Closed gfacciol closed 3 years ago

gfacciol commented 3 years ago

These new parameters control two aspects of MGM. By default the behavior of MGM and thus s2p is unchanged.

mgm_leftright_control=2 will skip the left-right check at coarser scales, improving matching speed and memory use
mgm_mindiff_control=-1 disables the mindiff test which will increase the density of DSM on slopes

# controls the mgm left-right consistency check. 0: disabled, 1 (default): enabled at all scales, 2: enables only at the last scale (faster)
cfg['mgm_leftright_control'] = 1

# controls the mgm mindiff filter check. 1 (default): enabled produces conservative results, -1: disabled (produce denser maps)
cfg['mgm_mindiff_control'] = 1

carlodef commented 3 years ago

Default value of MINDIFF in mgm is actually -1, so the tests expected results were produced without mindiff filtering. This is why the tests are failing with mgm_mindiff_control default value set to 1. I'm updating it to -1.